[lmi-commits] [5676] Improve a misleading function name

[Greg Chicares]

Revision: 5676
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=5676
Author:   chicares
Date:     2013-04-14 14:00:43 +0000 (Sun, 14 Apr 2013)
Log Message:
-----------
Improve a misleading function name

Modified Paths:
--------------
    lmi/trunk/configurable_settings.cpp
    lmi/trunk/configurable_settings.hpp
    lmi/trunk/ledger_text_formats.cpp

Modified: lmi/trunk/configurable_settings.cpp
===================================================================
--- lmi/trunk/configurable_settings.cpp 2013-04-14 13:41:04 UTC (rev 5675)
+++ lmi/trunk/configurable_settings.cpp 2013-04-14 14:00:43 UTC (rev 5676)
@@ -31,17 +31,17 @@
 
 #include "alert.hpp"
 #include "contains.hpp"
-#include "data_directory.hpp"     // AddDataDir()
+#include "data_directory.hpp"           // AddDataDir()
 #include "handle_exceptions.hpp"
-#include "miscellany.hpp"         // lmi_array_size()
-#include "path_utility.hpp"       // validate_directory(), validate_filepath()
-#include "platform_dependent.hpp" // access()
+#include "miscellany.hpp"               // lmi_array_size()
+#include "path_utility.hpp"             // validate_directory(), 
validate_filepath()
+#include "platform_dependent.hpp"       // access()
 
 #include <boost/filesystem/fstream.hpp>
 #include <boost/filesystem/operations.hpp>
 #include <boost/filesystem/path.hpp>
 
-#include <algorithm> // std::copy()
+#include <algorithm>                    // std::copy()
 #include <iterator>
 #include <sstream>
 #include <stdexcept>
@@ -417,7 +417,7 @@
     return xsl_fo_command_;
 }
 
-std::vector<std::string> effective_calculation_summary_columns()
+std::vector<std::string> parsed_calculation_summary_columns()
 {
     configurable_settings const& z = configurable_settings::instance();
     std::istringstream iss

Modified: lmi/trunk/configurable_settings.hpp
===================================================================
--- lmi/trunk/configurable_settings.hpp 2013-04-14 13:41:04 UTC (rev 5675)
+++ lmi/trunk/configurable_settings.hpp 2013-04-14 14:00:43 UTC (rev 5676)
@@ -118,7 +118,7 @@
     ~configurable_settings();
 };
 
-std::vector<std::string> effective_calculation_summary_columns();
+std::vector<std::string> parsed_calculation_summary_columns();
 
 #endif // configurable_settings_hpp
 

Modified: lmi/trunk/ledger_text_formats.cpp
===================================================================
--- lmi/trunk/ledger_text_formats.cpp   2013-04-14 13:41:04 UTC (rev 5675)
+++ lmi/trunk/ledger_text_formats.cpp   2013-04-14 14:00:43 UTC (rev 5676)
@@ -33,7 +33,7 @@
 #include "authenticity.hpp"
 #include "calendar_date.hpp"
 #include "comma_punct.hpp"
-#include "configurable_settings.hpp"    // 
effective_calculation_summary_columns()
+#include "configurable_settings.hpp"    // parsed_calculation_summary_columns()
 #include "contains.hpp"
 #include "global_settings.hpp"
 #include "ledger.hpp"
@@ -166,13 +166,13 @@
     ,invar_     (ledger_values.GetLedgerInvariant())
     ,max_length_(ledger_values.GetMaxLength())
 {
-    columns_ = effective_calculation_summary_columns();
+    columns_ = parsed_calculation_summary_columns();
     std::vector<std::string>::iterator p = std::find
         (columns_.begin()
         ,columns_.end()
         ,"PolicyYear"
         );
-    // TODO ?? This should be done in effective_calculation_summary_columns(),
+    // TODO ?? This should be done in parsed_calculation_summary_columns(),
     // but that requires a difficult-to-test change in 'ledger_xml_io2.cpp'.
     // As long as "PolicyYear" is always the first column, it shouldn't be
     // offered for selection anyway.