[lmi-commits] [6274] Improve comprehensibility

[Greg Chicares]

Revision: 6274
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6274
Author:   chicares
Date:     2015-08-28 17:04:23 +0000 (Fri, 28 Aug 2015)
Log Message:
-----------
Improve comprehensibility

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/group_quote_pdf_gen_wx.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2015-08-28 16:45:38 UTC (rev 6273)
+++ lmi/trunk/ChangeLog 2015-08-28 17:04:23 UTC (rev 6274)
@@ -36741,3 +36741,9 @@
 Escape XML special characters. See:
   http://lists.nongnu.org/archive/html/lmi/2015-08/msg00056.html
 
+20150828T1704Z <address@hidden> [477]
+
+  group_quote_pdf_gen_wx.cpp
+Improve comprehensibility. See:
+  http://lists.nongnu.org/archive/html/lmi/2015-08/msg00053.html
+

Modified: lmi/trunk/group_quote_pdf_gen_wx.cpp
===================================================================
--- lmi/trunk/group_quote_pdf_gen_wx.cpp        2015-08-28 16:45:38 UTC (rev 
6273)
+++ lmi/trunk/group_quote_pdf_gen_wx.cpp        2015-08-28 17:04:23 UTC (rev 
6274)
@@ -374,7 +374,8 @@
             {
             case e_col_number:
                 {
-                rd.values[col] = wxString::Format("%d", 
++row_num_).ToStdString();
+                // Row numbers shown to human beings should be 1-based.
+                rd.values[col] = wxString::Format("%d", row_num_ + 
1).ToStdString();
                 }
                 break;
             case e_col_name:
@@ -462,10 +463,11 @@
         }
 
     // The last, composite, ledger is only used for the totals, it shouldn't be
-    // shown in the main table.
+    // shown in the main table nor counted as a row.
     if(!is_composite)
         {
         rows_.push_back(rd);
+        row_num_++;
         }
 }
 
@@ -802,7 +804,7 @@
         ,escape_for_html_elem(report_data_.product_)
         ,escape_for_html_elem(report_data_.contract_state_)
         ,escape_for_html_elem(report_data_.available_riders_)
-        ,row_num_ - 1 // "- 1": don't count the composite.
+        ,row_num_
         );
 
     int const summary_height = output_html