[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 4b0c2ee 4/6: Remove an unreachable statement
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 4b0c2ee 4/6: Remove an unreachable statement |
Date: |
Tue, 28 Feb 2017 22:02:58 -0500 (EST) |
branch: master
commit 4b0c2eeb402a36b63038f604ab8fe4b37ca5be7d
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Remove an unreachable statement
fatal_error() always throws. Writing 'return' after it was just
confusing. (Elsewhere in lmi, this usage is seen:
throw "Unreachable--silences a compiler diagnostic.";
but there is no diagnostic to silence here.)
---
input_sequence_entry.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/input_sequence_entry.cpp b/input_sequence_entry.cpp
index 4cfabc9..68d2a5a 100644
--- a/input_sequence_entry.cpp
+++ b/input_sequence_entry.cpp
@@ -528,7 +528,6 @@ std::string InputSequenceEditor::sequence_string()
case e_inforce:
{
fatal_error() << "unexpected duration_mode value" << LMI_FLUSH;
- return "";
}
break;
}
- [lmi-commits] [lmi] master updated (86aacf1 -> b56fb86), Greg Chicares, 2017/02/28
- [lmi-commits] [lmi] master 2afd2fe 3/6: Improve concinnity, Greg Chicares, 2017/02/28
- [lmi-commits] [lmi] master 00c737d 1/6: Ensure that parser issues a diagnostic when insanity detected, Greg Chicares, 2017/02/28
- [lmi-commits] [lmi] master 4b0c2ee 4/6: Remove an unreachable statement,
Greg Chicares <=
- [lmi-commits] [lmi] master b56fb86 6/6: Canonicalize a near-canonical result, Greg Chicares, 2017/02/28
- [lmi-commits] [lmi] master 0d3c75a 5/6: Improve readability, Greg Chicares, 2017/02/28
- [lmi-commits] [lmi] master 3de3cf5 2/6: s12n(c14n), Greg Chicares, 2017/02/28