[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 4b30b4a 4/4: Refactor for clarity
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 4b30b4a 4/4: Refactor for clarity |
Date: |
Wed, 1 Mar 2017 05:57:11 -0500 (EST) |
branch: master
commit 4b30b4ae1b7be300ce0f05f95d25475d394091e3
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Refactor for clarity
As noted in the last commit, only validate_duration() should set
last_input_duration_. The original code (now changed) set it in
null_duration(), which called validate_duration(), which set it to
the same value--so modifying it in null_duration() actually had no
effect anyway, and this really is just a refactoring.
---
input_sequence_parser.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/input_sequence_parser.cpp b/input_sequence_parser.cpp
index e3e567f..74cdd10 100644
--- a/input_sequence_parser.cpp
+++ b/input_sequence_parser.cpp
@@ -202,9 +202,9 @@ void SequenceParser::duration_scalar()
void SequenceParser::null_duration()
{
- int trial_begin_duration = last_input_duration_++;
+ int trial_begin_duration = last_input_duration_;
duration_mode trial_begin_mode = previous_duration_scalar_mode_;
- int trial_end_duration = last_input_duration_;
+ int trial_end_duration = 1 + last_input_duration_;
duration_mode trial_end_mode = e_duration;
validate_duration
(trial_begin_duration