[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master a1d3016 01/10: Improve a MinGW conditional
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master a1d3016 01/10: Improve a MinGW conditional |
Date: |
Sat, 11 Mar 2017 17:24:20 -0500 (EST) |
branch: master
commit a1d30164367f0ced8fdf92772bff5a6aa76b56a6
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Improve a MinGW conditional
What had been expressed as a gcc-version difference may actually be a
MinGW-w64 regression. Now it is presented as a variation between MinGW
forks.
---
so_attributes.hpp | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/so_attributes.hpp b/so_attributes.hpp
index 8dc0fbc..90e2117 100644
--- a/so_attributes.hpp
+++ b/so_attributes.hpp
@@ -104,15 +104,17 @@
// That worked for MinGW up to gcc-3.4.5; for MinGW-w64 gcc-4.9.1, it
// elicits a warning, and ATTRIB must be dropped from the forward
// declaration. No knowledge is claimed of the behavior of gcc
-// versions between these two, which lmi did not use.
+// versions between these two, which lmi did not use. It is unknown
+// whether this difference represents deliberate evolution of gcc or
+// a MinGW-w64 regression, so both versions are preserved.
#if defined LMI_USE_SO_ATTRIBUTES
# if defined __GNUC__
-# if LMI_GCC_VERSION < 40901
-# define LMI_SO_FWD_DECL LMI_SO
-# else // !(LMI_GCC_VERSION < 40901)
+# if defined LMI_MINGW_W64
# define LMI_SO_FWD_DECL
-# endif // !(LMI_GCC_VERSION < 40901)
+# else // !defined LMI_MINGW_W64
+# define LMI_SO_FWD_DECL LMI_SO
+# endif // !defined LMI_MINGW_W64
# else // !defined __GNUC__
# define LMI_SO_FWD_DECL LMI_SO
# endif // !defined __GNUC__
- [lmi-commits] [lmi] master updated (e41c2a5 -> 14a3331), Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master 4d5ba79 03/10: Improve #error messages, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master a1d3016 01/10: Improve a MinGW conditional,
Greg Chicares <=
- [lmi-commits] [lmi] master cdd64d2 04/10: Remove a superannuated gcc conditional, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master 649d990 02/10: Improve documentation, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master d5d71f8 08/10: Refactor for simplicity, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master 58c9fdf 05/10: Make a precondition check unconditional, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master a4d4c24 06/10: Treat unknown platform as an error, uniformly, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master b1c6af9 07/10: Use similar logic for ELF and PE-COFF, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master b29be96 09/10: Extend in the spirit of ELF visibility, Greg Chicares, 2017/03/11
- [lmi-commits] [lmi] master 14a3331 10/10: Reuse recent so_attributes work for wx_new [394], Greg Chicares, 2017/03/11