[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 859e100 1/6: Move implementation of pure virt
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 859e100 1/6: Move implementation of pure virtual dtor out of header |
Date: |
Mon, 13 Mar 2017 09:46:13 -0400 (EDT) |
branch: master
commit 859e1005916545088e4dfb2a1b548eb5c8524e6b
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Move implementation of pure virtual dtor out of header
See:
http://lists.nongnu.org/archive/html/lmi/2017-03/msg00035.html
This commit essentially reverted the 20170306T1014 change, captioned
Implement pure virtual dtor inline in header
but retained the commentary changes.
---
datum_sequence.cpp | 9 +++++++++
datum_sequence.hpp | 9 ---------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/datum_sequence.cpp b/datum_sequence.cpp
index f97fa15..2cf6c01 100644
--- a/datum_sequence.cpp
+++ b/datum_sequence.cpp
@@ -46,6 +46,15 @@ datum_sequence::datum_sequence(std::string const& s)
assert_sanity();
}
+/// Implementation of pure virtual destructor.
+///
+/// Neither this explicitly-defaulted implementation nor any other can
+/// be written inside the class definition because C++11 [10.4/3] says
+/// "a function declaration cannot provide both a pure-specifier and a
+/// definition".
+
+datum_sequence::~datum_sequence() = default;
+
datum_sequence& datum_sequence::operator=(std::string const& s)
{
datum_string::operator=(s);
diff --git a/datum_sequence.hpp b/datum_sequence.hpp
index 1e218d3..c6cc9bc 100644
--- a/datum_sequence.hpp
+++ b/datum_sequence.hpp
@@ -94,15 +94,6 @@ class datum_sequence
bool keyword_values_are_blocked_;
};
-/// Implementation of pure virtual destructor.
-///
-/// Neither this explicitly-defaulted implementation nor any other can
-/// be written inside the class definition because C++11 [10.4/3] says
-/// "a function declaration cannot provide both a pure-specifier and a
-/// definition".
-
-inline datum_sequence::~datum_sequence() = default;
-
bool operator==(datum_sequence const&, datum_sequence const&);
// Specialize value_cast<> for each derived class, e.g., as follows:
- [lmi-commits] [lmi] master updated (197119c -> b98ef0c), Greg Chicares, 2017/03/13
- [lmi-commits] [lmi] master 859e100 1/6: Move implementation of pure virtual dtor out of header,
Greg Chicares <=
- [lmi-commits] [lmi] master 9ef5990 2/6: Disable gcc -Wcast-qual warning for wx in the code, not makefile, Greg Chicares, 2017/03/13
- [lmi-commits] [lmi] master b98ef0c 6/6: Refactor for clarity [392], Greg Chicares, 2017/03/13
- [lmi-commits] [lmi] master ba65912 5/6: Include the appropriate PCH header, Greg Chicares, 2017/03/13
- [lmi-commits] [lmi] master 351bf57 4/6: Improve documentation, Greg Chicares, 2017/03/13
- [lmi-commits] [lmi] master 25b5804 3/6: Remove the now unnecessary wx/defs.h inclusions, Greg Chicares, 2017/03/13