[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 082dd93 3/5: Move [[noreturn]] from definitio
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 082dd93 3/5: Move [[noreturn]] from definition to declaration |
Date: |
Wed, 15 Mar 2017 10:16:24 -0400 (EDT) |
branch: master
commit 082dd930d9afd969c14691ce3f5f1c152323d1fe
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Move [[noreturn]] from definition to declaration
See:
http://lists.nongnu.org/archive/html/lmi/2017-03/msg00089.html
and the followup discussion. It seems clear that it was wrong to write
the attribute on the function's definition but not on its declaration.
It is less clear whether it can be written on both; this commit follows
the interpretation that it can be written only on a declaration.
---
any_member.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/any_member.hpp b/any_member.hpp
index c04665a..3c41858 100644
--- a/any_member.hpp
+++ b/any_member.hpp
@@ -548,6 +548,7 @@ class MemberSymbolTable
MemberSymbolTable(MemberSymbolTable const&) = delete;
MemberSymbolTable& operator=(MemberSymbolTable const&) = delete;
+ [[noreturn]]
void complain_that_no_such_member_is_ascribed(std::string const&) const;
member_map_type map_;
@@ -567,7 +568,6 @@ MemberSymbolTable<ClassType>::~MemberSymbolTable() =
default;
// addition is attempted.
template<typename ClassType>
-[[noreturn]]
void MemberSymbolTable<ClassType>::complain_that_no_such_member_is_ascribed
(std::string const& name
) const