[lmi-commits] [lmi] master 026ae0a 3/4: Dismiss a marked defect [382]

[Greg Chicares]

branch: master
commit 026ae0a314abbcb44cf61117a8f984826e695779
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Dismiss a marked defect [382]
    
    Removed a comment that suggested special-case handling for a progress
    dialog that is used to count exactly zero steps. This special case no
    longer arises, and isn't worth spending time on now.
---
 progress_meter_wx.cpp | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/progress_meter_wx.cpp b/progress_meter_wx.cpp
index 1e96244..3621d37 100644
--- a/progress_meter_wx.cpp
+++ b/progress_meter_wx.cpp
@@ -78,11 +78,18 @@ class concrete_progress_meter
     wxGenericProgressDialog progress_dialog_;
 };
 
-// TODO ?? CALCULATION_SUMMARY Resolve this issue.
-// WX !! A wxProgressDialog created with maximum = 0 is displayed even
+// A wxProgressDialog created with maximum = 0 is displayed even
 // though that's apparently just a nuisance. Calling Update(0) right
-// after creation seems to be a reasonable workaround, but it would be
-// better to change this in the library itself.
+// after creation seems to be a reasonable workaround. This situation
+// no longer occurs in practice as this is written in 2017-11, though
+// formerly it did arise with an earlier version of the calculation
+// summary, where some number (determined at runtime) of columns were
+// updated in a context where that number might be zero. It doesn't
+// make much sense to change wx to treat this as a special case: the
+// wxProgressDialog implementation calls neither ShowModal() nor
+// Show(), so it is reasonable always to show the dialog. It might
+// make sense to treat this as a special case in this ctor, but it
+// doesn't seem to be worth the bother.
 
 concrete_progress_meter::concrete_progress_meter
     (int                               max_count