lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Dataview vs. listview appearance [PATCH]


From: Greg Chicares
Subject: Re: [lmi] Dataview vs. listview appearance [PATCH]
Date: Sun, 07 Aug 2011 21:50:49 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10

On 2011-07-30 13:04Z, Vaclav Slavik wrote:
> 
> On 2011-07-16 21:10, Václav Slavík wrote:
>>> > (1) Vertical spacing has widened. (It may be easier to read, but fewer
>>> > rows fit on the screen.)
>>
>> There's wxDataViewCtrl::SetRowHeight(), so it may be tweakable without 
>> changes to wx,
>> although I suspect not: I think the current size is the minimal one already, 
>> so
>> we'll have to change wxDVC to allow smaller sizes.

That's what the documentation seems to say:

http://docs.wxwidgets.org/trunk/classwx_data_view_ctrl.html
| this method can only be used to increase the row height compared with the 
default one

> Fortunately, that wasn't the case, wxDataViewCtrl hardcodes the height of 
> wxListCtrl
> with 16px icons, so the fix is simple:

Applied 20110807T2144Z, revision 5235.

I guess I've applied this somewhat out of order, because the new block
begins at line 303 in lmi HEAD instead of 939:

> diff --git a/census_view.cpp b/census_view.cpp
> index 4ecb893..ba193e4 100644
> --- a/census_view.cpp
> +++ b/census_view.cpp
> @@ -939,6 +939,12 @@ wxWindow* CensusView::CreateChildWindow()

but I thought it'd be nice to release this change this month.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]