Re: [lmi] Empty xml child text nodes [Was: product editor patch]

[Václav Slavík]

Hi,

On 27 Feb 2012, at 17:27, Greg Chicares wrote:
>> No, such behavior is desirable. It's not backward compatible (some
>> xmlwrapp-using code may rely on the fact that a child text node is
>> always created), but I think the incompatibility is extremely minor
>> and will apply this patch on xmlwrapp proper.
> 
> I doubt that lmi relies on the existence of empty child nodes,

I was primarily concerned about others' uses of xmlwrapp that we are not aware 
of...

> but it's not trivial to prove; if that incompatibility arises, will an
> exception be thrown?

It depends on what would such code do... If it dereferenced an invalid iterator 
(assuming that it was valid), it could probably crash.

>> Here are xmlwrapp changes since 0.6.0 for reference:
>> https://github.com/vslavik/xmlwrapp/blob/master/NEWS
> 
> Is that xmlwrapp's primary residence now? I ask because a large
> corporation that uses lmi has started blocking sourceforge.net,
> and we're asking them to unblock it; should we include github.com,
> too, or do you plan to mirror new releases on sf?

Yes, the code and issue tracker are hosted at github now. I'll probably keep 
the files at sf.net (last time I looked into it, it was more convenient that 
github file hosting), but the rest will stay at github.

Regards,
Vaclav