lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH 1/2] Make InputSequenceEntry friendly to embedding in w


From: Vadim Zeitlin
Subject: Re: [lmi] [PATCH 1/2] Make InputSequenceEntry friendly to embedding in wxDVC.
Date: Wed, 6 Feb 2013 13:55:49 +0100

On Tue, 09 Aug 2011 11:40:51 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2011-08-09 09:41Z, Vadim Zeitlin wrote:
GC> > On Tue, 9 Aug 2011 11:16:03 +0200 Václav Slavík <address@hidden> wrote:
GC> > 
GC> > VS> On 8 Aug 2011, at 20:26, Greg Chicares wrote:
GC> > VS> > I'd really like to hear the answer, too--AFAICT, 
TransferDataFromWindow()
GC> > VS> > shouldn't be called by wx (or at least by wxmsw) unless an Apply 
button
GC> > VS> > is pressed or AcceptAndClose() is called.
GC> > VS> 
GC> > VS> The answer lies in LMI's MvcController::UponUpdateUI(), which is 
called
GC> > VS> at idle time and calls TransferDataFromWindow():
GC> > 
GC> >  Indeed, I can now see it as well
GC> 
GC> Me too, now that you point it out. I was staring at it yesterday--it's the 
only
GC> place lmi calls TransferDataFromWindow()--but, even though the tabbed-dialog
GC> .xrc files specify wxWS_EX_VALIDATE_RECURSIVELY, I didn't imagine it would
GC> recurse into a pop-up dialog.

 Following the "better late than never" principle, I've finally changed
this behaviour in wxWidgets in http://trac.wxwidgets.org/changeset/73482
(the previous revision is also related), so that this finally won't happen
any more in wxWidgets 2.9.5. Even if this doesn't affect LMI directly
because another fix was used, I wanted to let you know about it so that you
knew that you don't have to worry about unexpectedly recursing into a child
dialog any more.

 Regards,
VZ

reply via email to

[Prev in Thread] Current Thread [Next in Thread]