Re: [lmi] Wrong wxFlexGridSizer usage in about_dialog.cpp

[Greg Chicares]

On 2010-01-22 17:39, Greg Chicares wrote:
> On 2010-01-21 13:26Z, Greg Chicares wrote:
>> On 2010-01-21 11:06Z, Vadim Zeitlin wrote:
>>> On Thu, 21 Jan 2010 02:39:27 +0000 Greg Chicares <address@hidden> wrote:
>>> 
>>> GC> The proportional font helps to condense the license, as mentioned here:
>>> GC>   http://lists.nongnu.org/archive/html/lmi/2010-01/msg00018.html
>>> GC> and, for uniformity, revision 4745 uses that font on the "Help | About"
>>> GC> dialog as well. And the inadequate margins around pushbuttons noted in
>>> GC> that message were fixed in revision 4739.

In revision 4745 I introduced a magic constant with value 450:
  
http://svn.savannah.nongnu.org/viewvc/lmi/trunk/about_dialog.cpp?root=lmi&r1=4744&r2=4745
I'm not sure where that value came from, but it looks awful at 192 DPI.
I'll send a screenshot to anyone who asks, but plain text may be enough:
  This program is free software; you
  can redistribute it and/or modify it
  under the terms of the GNU General
  Public License...
The end is truncated; it's impossible to read the entire statement because
there is no scrollbar and the user cannot resize this modal dialog.

It looks a lot better if I double the value to 900, but that'll probably
make it look awful at 96 DPI, and magic constants are a code smell anyway.
What's the right way to accomplish the aesthetic goals spelled out in this
old thread?

In 2010 we decided that wxSystemSettings wasn't the perfect tool for this
task, but I'm wondering whether that conclusion pertained only to the
scrollbar that was removed in revision 4747.