lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] [PATCH] Integrate wxPdfDocument into lmi build system


From: Vadim Zeitlin
Subject: [lmi] [PATCH] Integrate wxPdfDocument into lmi build system
Date: Fri, 24 Jul 2015 02:21:43 +0200

 Hello,

 This is another series of preliminary patches, just as the ledger emission
code refactoring one[*]. The two series are independent of each other, so
could be applied in any order, but both of them are needed by the upcoming
changes adding group premiums PDF report generation to lmi.

 As usual, I hope the commit messages are self-explanatory, so let me just
reproduce them here with only a couple of extra remarks:

--------------------------------------------------------------------------------
Don't disable wxRegEx when building wxWidgets.

Although lmi doesn't use this class on its own, third-party libraries such as
soon to be added wxPdfDocument may need it, so stop explicitly disabling it
when building wxWidgets.

(this is basically a prerequisite for building wxPdfDocument)
--------------------------------------------------------------------------------
Handle more options in portable wx-config.

More options than just --cxxflags and --libs are needed when wx-config is used
from the configure scripts of the libraries looking for the appropriate
version of wxWidgets to use, so make wx-config-portable usable in such
situations as well by handling calling it with more than one option at a time
and also processing more options.

(this commit is actually optional and can be skipped if you don't like it,
which is something I would totally understand as the changes to
install_wx.make definitely don't make it any prettier -- but then the next
commit would need to be modified to use the real wx-config in the configure
configure in install_wxpdfdoc.make as without these changes running
configure with the portable script would fail)
--------------------------------------------------------------------------------
Install wxPdfDocument library as part of lmi installation.

Create install_wxpdfdoc.make makefile similar to the existing install_xxx.make
ones and use it from the install_msw.sh installation script.

(the makefile could be improved and I plan to write a separate message
about this, but for now it's written in a way consistent with the other
existing makefiles and, at the very least, does work)
--------------------------------------------------------------------------------
Add a simple unit test for wxPdfDocument.

While the test is trivial, it is still useful if only to allow checking that
linking with the library succeeds, especially as it is relatively non trivial
because we need to painstakingly manually construct its name in our makefile.

(this commit is also somewhat optional as I'm not totally sure of its
value, but I decided to add it to basically just have a simple to test if
wxPdfDocument was built and installed successfully)
--------------------------------------------------------------------------------

 Please note that I don't include the changes to the autotools build system
as I don't want to flood you with patches and I plan to just commit them
directly when/if the patches above are applied.

 Finally, I did my best to test these changes, notably I verified that
running install_msw.sh still works (provided the necessary adjustments to
the Cygwin mirror is done and my other patch allowing to use wxWidgets 3.1
from GitHub is applied). BTW, as I wanted to test the patch in a fresh VM
and had to create one anyhow, I also decided to test it under Windows 8.1,
which I hadn't used with lmi so far (I could have used Windows 10 too, but
I decided that this would be too new...) and, just in case it can be
useful, I can say that everything seems to work just fine under this OS
version.

 Thanks in advance for looking at these patches!
VZ

[*] http://lists.nongnu.org/archive/html/lmi/2015-07/msg00012.html

Attachment: 0001-Don-t-disable-wxRegEx-when-building-wxWidgets.patch
Description: Text document

Attachment: 0002-Handle-more-options-in-portable-wx-config.patch
Description: Text document

Attachment: 0003-Install-wxPdfDocument-library-as-part-of-lmi-install.patch
Description: Text document

Attachment: 0004-Add-a-simple-unit-test-for-wxPdfDocument.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]