Re: [lmi] [PATCH] Fix columns width in the group premiums PDF

[Vadim Zeitlin]

On Sun, 20 Sep 2015 18:33:24 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2015-09-20 18:01, Vadim Zeitlin wrote:
GC> > 
GC> > [first attached patch] just allows me to compile
GC> > under MSVC without changes (I had it in my local branch before and can go
GC> > on keeping it there if you decide to not apply it, but it would be more
GC> > convenient to not have to do this)
GC> 
GC> I'll commit this (and the other patches) soon. I'm just curious about the
GC> first one, though: is the defect in the (original) code, or in msvc?
GC> I don't see why the original code was wrong.

 Sorry, I described the problem wrongly: actually the code is absolutely
correct and MSVC even does compile it, it's just that if the struct has
const fields it produces the following warnings:

group_quote_pdf_gen_wx.cpp(201): warning C4510: 
'`anonymous-namespace'::column_definition' : default constructor could not be 
generated
          group_quote_pdf_gen_wx.cpp(198) : see declaration of 
'`anonymous-namespace'::column_definition'
group_quote_pdf_gen_wx.cpp(201): warning C4610: struct 
'`anonymous-namespace'::column_definition' can never be instantiated - user 
defined constructor required

It's pretty strange that it doesn't also generate the warning C4512 which
is similar to C4510 but about the assignment operator, but even those two
are already annoying enough. And they can't be fixed by just defining a
ctor neither as then recent g++ start complaining that "extended
initializer lists only available with -std=c++11 or -std=gnu++11" and g++
3.4.5 just gives an error.

 Sorry again for the confusing initial description of the problem,
VZ