[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi] PR: Check that the run order is the same for all cells and the cas
From: |
Vadim Zeitlin |
Subject: |
[lmi] PR: Check that the run order is the same for all cells and the case |
Date: |
Fri, 2 Oct 2015 23:37:20 +0200 |
Hello,
Let me try to experiment with a new mechanism for patch submission: using
GitHub pull requests. It's a bit strange to use them when you don't use
GitHub (yet...), but it does have some advantages: you can view the patches
easily in a nice, coloured and syntax highlighting GitHub diff viewer and I
can keep track of different patches more easily. This would also allow
updating the patches if you make any comments about them here or on GitHub
(which is the simplest way to do it but does require a GitHub account --
OTOH GitHub account is as non intrusive as an account can be and doesn't
require you providing any information at all AFAIR). Of course, if you
don't like it and prefer the old way of submitting patches, please just let
me know and I'll revert to doing it like this.
But in the meanwhile, here is the first pull request, in all its glory:
https://github.com/vadz/lmi/pull/1
I plan to implement is_okay_to_run_group_quote() in a very similar way soon,
so please let me know if you have any comments about this change.
On an unrelated note, while benchmarking the effects of this change with
the "big census", I get this after ~40 (?) first cells
---------------------------
Error
---------------------------
While processing a decrease in policy month 0, policy year 2, 24 months
after beginning of most recent seven-pay period, cumulative premium should be
24201.1 but is 40000; discrepancy is 15798.9.
[file /opt/lmi/src/git/ihs_irc7702a.cpp, line 1061]
---------------------------
OK
---------------------------
It doesn't really bother me as the code being benchmarked is already
executed by the time the error happens, but if you know immediately why
does this error happen and, more importantly, how to fix it, I'd like to
know about it because I thought that it would be nice to test the PDF
output with 4200+ rows in this census to see if there are no unforeseen
problems with that many pages.
Thanks in advance,
VZ
[lmi] Big census [Was: PR: Check that the run order is the same for all cells and the case], Greg Chicares, 2015/10/08