Re: [lmi] Event handling modernization

[Greg Chicares]

On 2014-11-30 01:04, Vadim Zeitlin wrote:
> On Sun, 09 Nov 2014 20:35:34 +0000 Greg Chicares <address@hidden> wrote:
[...]
> But I won't go into
> the details as I have been told (several times) that, incredible as it may
> seem, not everyone is interested in software archaeology.

Anyone who has such an incredible viewpoint should stop reading here.

> (0001-Handle-only-the-menu-open-events-for-the-main-frame-.patch)

I think that's been subsumed into
  https://github.com/vadz/lmi/pull/8
committed 20160330T2224Z, revision 6543.

>  The 0002-Don-t-count-all-MDI-children-just-check-if-there-is-.patch one
> addresses my urge to avoid performing unnecessary actions: we don't really
> need the count of MDI children frame here at all, so why bother counting
> all of them (even if "all" is probably virtually always just a few) when we
> can stop after just the second one? Subsidiarily, why count them at all if
> we don't have any active child anyhow.
> 
>  The 0003-Remove-unnecessary-DocMDIChildFrameEx-dtor.patch removes a
> "WX !!" comment which is not relevant any more (and since quite some time,
> too), bringing the total count of such remaining comments to "only" 45 (2%
> decrease!).

Those little improvements add up:

/lmi/src/lmi[0]$grep --directories=skip 'WX !!' * |wc -l

40


>  Finally, 0004-Remove-the-attempts-to-use-MDI-parent-status-bar-for.patch

Committed 20160330T2141Z, revision 6541.

>  And to really conclude this topic, I'd like to add that, while debugging
> this, I did find a minor problem related to the help strings: they were not
> shown at all for the items in a popup menu (e.g. the one shown when right
> clicking in a census window). Unfortunately this is something that can't be
> worked around at LMI level, it turned out to be a real bug in wxWidgets and
> I had to fix it there. Nothing is required for this fix to work for LMI:
> when you update to a later revision (I can't give the exact commit as I
> haven't committed it just yet because the wxWidgets svn repository server
> has some problems right now), whether you apply the above patch or not, you
> will just see the help strings in the status bar for the popup menu items
> as well.

This works now.