lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] [PATCH] Allow selecting the skin to use during run time


From: Vadim Zeitlin
Subject: [lmi] [PATCH] Allow selecting the skin to use during run time
Date: Mon, 2 May 2016 01:01:55 +0200

 Hello,

 I've completely forgot about a request to implement changing the skin
during run-time that was made already half a year ago and only recently
rediscovered it (with a few other ones, but which seem to be less
important) carefully hidden in my notes. As this was deemed to be
"important" back then, I hope it's still is useful and here is the patch
implementing it: https://github.com/vadz/lmi/pull/27

 The commits there should be self-explanatory, but I just hope that I
understood correctly the reason for having the "TODO ??" comments in the
code which I fixed in https://github.com/vadz/lmi/pull/27/commits/15f3d5f
i.e. that my changes are really the fix. Please let me know if I missed the
point.

 The real changes are in https://github.com/vadz/lmi/pull/27/commits/e56e18b
and the main problem I have with this commit is that it duplicates too much
of ce_product_name.?pp code in the new ce_skin_name.?pp files. I could
improve this by refactoring the code further to avoid this duplication but
this would inevitably entail changes to the existing ce_product_name code
and I didn't want to do this without your agreement -- please let me know
if I should do this.

 Another potential problem is that currently the skin selection is made
available to the end user in the preferences dialog unconditionally. I
don't see how could it do any harm, but it would, of course, be simple to
guard this by the uniquely circular password, as usual.

 Please let me know if you'd like me to change this or anything else,
VZ


reply via email to

[Prev in Thread] Current Thread [Next in Thread]