Re: [lmi] Allow switching skin while lmi is running

[Vadim Zeitlin]

On Mon, 30 May 2016 14:04:03 +0000 Greg Chicares <address@hidden> wrote:

GC> Now we have
GC>   ce_product_name.?pp
GC>   ce_skin_name.?pp
GC> and the first determines its enumerators in
GC>   product_names.?pp
GC> while the second does that in an unnamed namespace in the 'ce_' source.
GC> 
GC> I'd like to determine the enumerators in a parallel location for both:
GC> that makes code review and future maintenance easier. Do you strongly
GC> prefer that I not create new
GC>   skin_names.?pp
GC> files?

 No, not really strongly, but I think I prefer to keep them private in that
file just because I don't see any reason to "export" them. Why not merge
product_names.cpp with ce_product_name.cpp instead? These files are not big
at 134 and 89 lines respectively, so, accounting for licence duplication
and such, the combined file would be ~200 lines only, and would neatly
contain everything related to the product names.

 Is there some advantage of keeping these functions in a separate file I'm
missing?

VZ