lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Removing empty messages from static_assert()


From: Vadim Zeitlin
Subject: Re: [lmi] Removing empty messages from static_assert()
Date: Fri, 9 Feb 2018 23:17:16 +0100

On Fri, 9 Feb 2018 21:04:09 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2018-02-09 19:52, Greg Chicares wrote:
GC> > On 2018-02-09 16:36, Vadim Zeitlin wrote:
GC> > [...]
GC> >>  Would you mind if I submitted a trivial patch removing all of these ""
GC> >> from static_assert?
GC> 
GC> I've received no copy of my original reply:
GC>   http://lists.nongnu.org/archive/html/lmi/2018-02/msg00052.html
GC> but...belay that. I'll apply your PR 64 and PR 65 first, and
GC> apply the patch below as you had suggested. I have no plans to
GC> change anything else soon, so you can make your static_assert
GC> patch on top of those changes (as you were probably planning
GC> to do anyway), and I'll apply it when I see it.

 Thanks, here is the PR with the (as announced, trivial, changes):

        https://github.com/vadz/lmi/pull/66

I've only tested its compilation (with MinGW and MSVS 2017 too) because
it's really not supposed to have any run-time effects.

GC> And, BTW, Ctrl-R shows this in my history:
GC>   git cherry-pick ..xanadu/pdf-pagination-fix
GC> so I've already applied PR 63;

 Yes, sorry, I forgot to close it -- done now.
VZ


reply via email to

[Prev in Thread] Current Thread [Next in Thread]