Re: [Ltib] Bug in ltib

[Stuart Hughes]

Svein Seldal wrote:
> Stuart Hughes wrote:
> > Hi Svein,
> >
> > This is odd but deliberate.  rpm-fs is a bootstrap package and having 
> > it this way avoids re-downloading if your initial install of rpm-fs 
> > fails (IIRC).  As it's in /tmp/... then it will get cleaned up by 
> > logwatch after a period of time.
>
> Hmm. I have to admit I don't like this approach. /tmp is considered a 
> temporary storage, and every app should behave nicely by cleaning up 
> afterwards. Some distros uses RAM based fs on /tmp and thus has limited 
> space. By not cleaning up will slow down the system.
>
> In addition logwatch is not installed per default on Ubuntu, so there's 
> nothing expiring the /tmp files. (Unless there's another /tmp cleaning 
> daemon I don't know of.)

I tend to agree.  I've checked in this patch which will keep /tmp clean 
as the downloads are within the temporary rpm build area which is 
cleaned up.

Index: ltib
===================================================================
RCS file: /sources/ltib/ltib/ltib,v
retrieving revision 1.35
diff -u -r1.35 ltib
--- ltib        2 Jul 2009 13:48:34 -0000       1.35
+++ ltib        6 Jul 2009 13:16:10 -0000
@@ -2386,8 +2386,6 @@
     $cf->{sysconfdir}    = "$cf->{defpfx}/etc";
     chomp($cf->{rpmbuild} = `which rpmbuild 2>/dev/null` || "rpm\n");
     $cf->{rpm}           = "rpm";
-    $cf->{lpp}           = "/tmp";
-    $cf->{ldirs}         = $cf->{lpp};
     $cf->{tmppath}       = $cf->{projtmp};
     $cf->{enrootn}       = 0;

@@ -2397,6 +2395,8 @@
     $cf->{rpmdir} =~ s,[\\],-,g;
     $cf->{_rpmdir} = "$cf->{rpmdir}/RPMS";
     $cf->{rpmdb}  = "$cf->{rpmdir}/rpmdb";
+    $cf->{lpp}    = "$cf->{rpmdir}";
+    $cf->{ldirs}  = $cf->{lpp};
     $cf->{sudo}   = "";
     setup_rpmdb();
     $cf->{sudo}   = $sav->{sudo};


Regards, Stuart