Re: [Ltib] Auestion regarding ltib.preconfig configuration changes and how to have LTIB follow it

[Mark]

Hello Stuart

I've just been looking at this patch and I don't think that it has applied 
correctly from the original email text.

I've checked out the latest version from CVS. The line in question is 2927:

if [ -f ${PLATFORM}.config -a ${PLATFORM}.config -nt

looks like it should be:

 if [ -f ${PLATFORM}.config -a ${PLATFORM}.config -nt $cf->{hostconfig} ]

I've attached a patch to correct this.

Regards

Mark

On Saturday 28 Apr 2012 10:54:48 Stuart Hughes wrote:
> Hi Peter,
> 
> Thanks for the patch, I've checked that into CVS.
> 
> Could I ask that in future you attach patches as a unified diff.  I find
> context diffs hard to follow, and inline patches get mangled by my mail
> client(s).
> 
> All: please let the list know if you see any regressions related to
> initial install (package list), or --hostcf behaviour.
> 
> Regards, Stuart
> 
> On 26/04/12 22:16, Peter Barada wrote:
> > On 04/26/2012 04:35 AM, Stuart Hughes wrote:
> >> Hi Peter,
> >> 
> >>  From memory; you're correct once you've run ltib it will not look at
> >> 
> >> ltib.preconfig any more.  You'd need to put the system back in the
> >> default state (distclean).  Alternatively you should be able to add the
> >> needed packages using the  ./ltib --hostcf -m config
> >> When you're done,  you can copy the result back to ltib.preconfig for a
> >> cold-build.
> >> 
> >> One thing to watch out for though is that when you run ./ltib --hostcf
> >> -m config it takes notice of all the collateral dependencies (intended
> >> for the target) and so the list of package you end up installing is more
> >> than if you just enabled the single packages in the ltib.preconfig file
> >> by hand.
> > 
> > Stuart, the following is a patch to current ltib to do:
> > 
> > 1) If you run "./ltib -b --hostcf" it won't ask to Drop a package that
> > is deselected in the host configuration
> > 2) If config/platform/host/ltib.preconfig is newer than
> > config/platform/host/{.config,host.config} it will copy
> > config/platform/host/ltib.preconfig into config/platform/host/.config
> > 
> > With this change, I can now run "./ltib -b --hostcf" as part of my
> > buildbot and changes in config/platform/host/ltib.preconfig will take
> > effect in that build.  Then I can run "./ltib -b --preconfig
> > config/platform/<platform>/defconfig" and everything just works.
> > 
> > I'm loathe to distclean on my buildbot setup since that causes LTIB to
> > unecessarily rebuild packages (and I don't want to do that for every
> > build done by buildbot).
> > 
> > *** ltib.~1.85.~    2012-04-26 13:13:34.000000000 -0400
> > --- ltib    2012-04-26 17:11:38.515832995 -0400
> > ***************
> > *** 1445,1451 ****
> > 
> >       if($host_pkg_dev == 1) {
> >       
> >           # we are working on host packages
> >           ltib_host_config();
> > 
> > !         $cf->{dodrop} = 'ask';
> > 
> >           exit 0 if $cf->{mode} eq 'config';
> >       
> >       } else {
> >       
> >           # this is the case where we are doing just the basic host
> >           packages
> > 
> > --- 1445,1451 ----
> > 
> >       if($host_pkg_dev == 1) {
> >       
> >           # we are working on host packages
> >           ltib_host_config();
> > 
> > !         $cf->{dodrop} = 'ask' unless $cf->{batch};
> > 
> >           exit 0 if $cf->{mode} eq 'config';
> >       
> >       } else {
> >       
> >           # this is the case where we are doing just the basic host
> >           packages
> > 
> > ***************
> > *** 2918,2926 ****
> > 
> >       system_nb(<<TXT) == 0 or die;
> >   
> >   set -ex
> >   cd $hostpath
> > 
> > ! if [ ! -f .config ]
> > 
> >   then
> > 
> > !     if [ -f ${PLATFORM}.config ]
> > 
> >       then
> >       
> >           cp ${PLATFORM}.config .config
> >       
> >       else
> > 
> > --- 2918,2931 ----
> > 
> >       system_nb(<<TXT) == 0 or die;
> >   
> >   set -ex
> >   cd $hostpath
> > 
> > ! if [ -f .config ]
> > 
> >   then
> > 
> > !     if [ $cf->{hostconfig} -nt ${PLATFORM}.config ]
> > !     then
> > !         cp $cf->{hostconfig} .config
> > !     fi
> > ! else
> > !     if [ -f ${PLATFORM}.config -a ${PLATFORM}.config -nt
> > $cf->{hostconfig} ]
> > 
> >       then
> >       
> >           cp ${PLATFORM}.config .config
> >       
> >       else
> 
> _______________________________________________
> LTIB home page: http://ltib.org
> 
> Ltib mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/ltib

host-config.patch
Description: Text Data