[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master
|
From: |
Sylvain Rochet |
|
Subject: |
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. b135a0aa4905d30b2fae0b67f7ee2dba2c4c12f7 |
|
Date: |
Thu, 19 Mar 2015 11:34:25 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hello Simon,
On Thu, Mar 19, 2015 at 06:14:38AM +0000, Simon Goldschmidt wrote:
>
> pppos_input_tcpip: fix pbuf leak if tcpip_input returns error, use
> pbuf_take instead of duplicate copy code
Oh!, thanks for that :)
I wonder how many lwIP ports are buggy concerning this point then.
I also wonder why pbuf_take() is done this way, isn't it guaranteed that
pbuf_alloc() returns either the wanted size or NULL ? Looks like it can
return less than the wanted size based on how pbuf_take() is written.
Sylvain
signature.asc
Description: Digital signature