[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master
From: |
Sylvain Rochet |
Subject: |
Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. 236bc194222b604f251cd86d4715cd05d9e40f94 |
Date: |
Mon, 27 Jun 2016 11:31:24 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Hi,
On Mon, Jun 27, 2016 at 08:31:43AM +0000, Simon Goldschmidt wrote:
>
> - Log -----------------------------------------------------------------
> commit 236bc194222b604f251cd86d4715cd05d9e40f94
> Author: goldsimon <address@hidden>
> Date: Mon Jun 27 10:31:36 2016 +0200
>
> fixed bug #48170 (patch by Fabian Koch)
Woah, what a meaningful commit message. Especially given the bug report
is verbose about the issue, you didn't have to write something new.
In addition, you stole Fabian's authorship, even if you need to rebase
the patch against master that's still not a good reason to steal
authorship.
More and more projects are now using Signed-off-by: tags in their commit
message, in order to give credits to those who rebase and are doing
small various changes but didn't write the initial diffset.
Sylvain
signature.asc
Description: Digital signature