[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. c2a5480ac7c55674928c4391a3f3d24e84ec321c

[Sylvain Rochet]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  c2a5480ac7c55674928c4391a3f3d24e84ec321c (commit)
       via  01561b26efad0218cf0f2fee60738039ca2ee038 (commit)
       via  9b47b6393b1f3f593a69a96e1acd95faba27459a (commit)
       via  e8d8c5dcc9b3ba42a96e70b49e1cd67ee1977b3b (commit)
       via  bae67915ab97db3f50a5d136fe81b897c70e7b08 (commit)
      from  5f774270b656c450dca9661e73cea822232387fb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c2a5480ac7c55674928c4391a3f3d24e84ec321c
Author: Sylvain Rochet <address@hidden>
Date:   Thu Aug 4 23:52:54 2016 +0200

    PPP: remove useless ppp_link_start function
    
    This function only set PPP to initialize phase, and it is only called at
    the very beginning of functions where it is called. It means we could
    as well set the initialize phase before calling those functions in the
    PPP core.

commit 01561b26efad0218cf0f2fee60738039ca2ee038
Author: Sylvain Rochet <address@hidden>
Date:   Thu Aug 4 23:43:46 2016 +0200

    PPP: set phase to establish before starting LCP
    
    PPP is currently in initialize phase until authentication is started
    or until we start IPCP negotiation.
    
    It works, because PPP states are mostly used for user information, most
    state are actually useless for PPP itself. Being in initialize state
    while PPP is started is not very consistent, switch to establish phase
    before starting LCP.

commit 9b47b6393b1f3f593a69a96e1acd95faba27459a
Author: Sylvain Rochet <address@hidden>
Date:   Thu Aug 4 23:06:30 2016 +0200

    PPP, PPPoE: remove useless PPPoE state conditions
    
    sc->sc_ethif can't be NULL, it is set definitively in pppoe_create.
    
    PPPoE can't by anything else than PADI sent in pppoe_send_padi, it
    is only called when this is true.
    
    PPPoE state can't be anything else than initial state in
    pppoe_connect, this function is called from PPP core only when PPP
    is in the dead phase, if PPP is in the dead phase it means the link
    protocol is dead as well.
    
    PPPoE can't be anything else than data phase in pppoe_disconnect
    this function is only called by PPP core only when PPP session is up,
    if PPP session is UP it means the link protocol is UP as well.
    
    PPPoE can't by anything else than PADR sent in pppoe_send_padr, it
    is only called when this is true.
    
    PPPoE can't by anything else than PADO sent in pppoe_send_pado, it
    is only called when this is true.
    
    PPPoE can't by anything else than PADO sent in pppoe_send_pads, it
    is only called when this is true.
    
    PPPoE can't be anything else than session phase in pppoe_xmit,
    function is only called by pppoe_write and pppoe_netif_output
    which are both called by PPP core only when PPP session is up, if
    PPP session is UP it means the link protocol is UP as well.

commit e8d8c5dcc9b3ba42a96e70b49e1cd67ee1977b3b
Author: Sylvain Rochet <address@hidden>
Date:   Thu Aug 4 23:03:03 2016 +0200

    PPP, L2TP: remove useless L2TP state conditions
    
    L2TP state can't be anything else than initial state in
    pppol2tp_connect, this function is called from PPP core only when PPP
    is in the dead phase, if PPP is in the dead phase it means the link
    protocol is dead as well.
    
    L2TP can't be anything else than data phase in pppol2tp_xmit, this
    function is only called by pppol2tp_write and pppol2tp_netif_output
    which are both called by PPP core only when PPP session is up, if
    PPP session is UP it means the link protocol is UP as well.
    
    L2TP can't be anything else than data phase in pppol2tp_disconnect,
    this function is only called by PPP core only when PPP session is up,
    if PPP session is UP it means the link protocol is UP as well.

commit bae67915ab97db3f50a5d136fe81b897c70e7b08
Author: Sylvain Rochet <address@hidden>
Date:   Thu Aug 4 22:06:45 2016 +0200

    PPP: fix dead phase set too early
    
    When we are disconnecting, we should switch to PPP dead phase at the
    very end, because this is our final disconnection phase allowing
    reconnect, therefore we should switch to dead phase after the link
    protocol finished disconnecting.
    
    We are currently switching to dead phase when LCP detected that the link
    is down, this is obviously wrong. Fix this flaw by continuing in
    disconnect phase until ppp_link_end is called from link protocol.

-----------------------------------------------------------------------

Summary of changes:
 src/include/netif/ppp/ppp_impl.h |    3 ---
 src/netif/ppp/auth.c             |    1 -
 src/netif/ppp/ppp.c              |   12 +++++-------
 src/netif/ppp/pppoe.c            |   38 --------------------------------------
 src/netif/ppp/pppol2tp.c         |   17 +----------------
 src/netif/ppp/pppos.c            |    2 --
 6 files changed, 6 insertions(+), 67 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack