[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. 455a41822ef28d8118c10a57fdec616633447805

[Sylvain Rochet]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  455a41822ef28d8118c10a57fdec616633447805 (commit)
       via  1ea10269614041d5a44b8a719b5496d9ac405631 (commit)
       via  09c22e13fe565301f883407998708c92a38d6b2f (commit)
       via  7c02a85424c558170d56c710bbba25456e9ac041 (commit)
       via  d15ebc6a4cd62f7637f7b05ed68c4adb98b6977b (commit)
       via  f185104ac6000a8d1fa779aecdbbd297da52e497 (commit)
       via  5811948b0abf1f7e2e8e6c1fcd2223f2e6121b10 (commit)
       via  dd0779c204a096f34a1cc8c5dca33a91b2293796 (commit)
      from  898e69118afc4a5daa35d6b4903513cb33eda217 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 455a41822ef28d8118c10a57fdec616633447805
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 23:20:09 2016 +0200

    PPP, PPPoL2TP: cleanup connection state reset
    
    Remove unnecessary cleanup at the end of session, cleanup as much as
    possible in the connect callback instead. It follows what PPPoE is
    currently doing and it makes everything simpler to read.

commit 1ea10269614041d5a44b8a719b5496d9ac405631
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 23:08:50 2016 +0200

    PPP, PPPoE: cleanup connection state reset
    
    Instead of relying on cleanup at the end of session, cleanup as much as
    possible in the connect callback. It removes duplicated code and make
    everything simpler to read.
    
    While we are at it, remove useless initialization code from create
    and connect functions.

commit 09c22e13fe565301f883407998708c92a38d6b2f
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 22:39:16 2016 +0200

    PPP: close link protocol if LCP is not started in ppp_close
    
    ppp_close might try to close LCP even if LCP is not started, it happens
    because because the PPP session might be waiting for the link protocol
    to come up and we do not check that.
    
    We say in the PPP documentation that ppp_close() can be called anytime,
    so, if link protocol is currently trying to connect, we must cancel
    the link connection.
    
    Fix it by calling the link protocol disconnect callback if LCP is not
    started yet.

commit 7c02a85424c558170d56c710bbba25456e9ac041
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 22:35:31 2016 +0200

    PPP, PPPoE: add support for disconnecting in link initiation state in 
disconnect callback
    
    Disconnect callback does not currently support a disconnect event while
    initiation is in progress. Retry timer is not stopped and PADT frame is
    sent whatever the current state is. PADT frame can only be sent if we
    received a PADS frame, otherwise sc_session is 0 and sending a PADT
    frame is meaningless.
    
    Fix both issues to allow calling the disconnect callback whatever the
    PPPoE state is.

commit d15ebc6a4cd62f7637f7b05ed68c4adb98b6977b
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 21:04:56 2016 +0200

    PPP: don't restart LCP closing if termination is already in progress
    
    We say in the PPP documentation that ppp_close() can be called anytime,
    as of today, this is not entirely true, there are still conditions that
    are not handled properly.
    
    If PPP is already disconnecting, ppp_close() must do nothing and returns
    ERR_INPROGRESS instead of messing up the PPP disconnection state.

commit f185104ac6000a8d1fa779aecdbbd297da52e497
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 20:54:14 2016 +0200

    PPP: revamp PPP state order
    
    Master state is almost exactly the same thing as dead state, move it
    next to dead state. Holdoff state is actually the state just before
    initialize, move it before initialize.
    
    The goal is to be able to use > running or => terminate condition to
    check a currently running disconnection phase, which is not possible
    today without excluding master and holdoff states.

commit 5811948b0abf1f7e2e8e6c1fcd2223f2e6121b10
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 20:50:08 2016 +0200

    PPP: remove PPP_PHASE_MASTER conditions if multilink mode is disabled
    
    PPP_PHASE_MASTER state is only used if multilink mode is enabled. Since
    we don't support multilink mode checking for this state only add some
    code for no value added at all.
    
    Build-out PPP_PHASE_MASTER state check if multilink mode is disabled.

commit dd0779c204a096f34a1cc8c5dca33a91b2293796
Author: Sylvain Rochet <address@hidden>
Date:   Sun Aug 7 19:27:50 2016 +0200

    PPP, move VJ_SUPPORT disabling if LWIP_TCP is not enabled to PPP options
    
    Van Jacobson TCP header compression only apply if TCP is enabled,
    therefore we need to disable VJ compression if TCP is disabled.
    
    We already have conditions to enforce VJ disabling if IPv4 is disabled
    or if PPPoS is disabled, add TCP to those conditions and remove
    unecessary VJ_SUPPORT && LWIP_TCP conditions.

-----------------------------------------------------------------------

Summary of changes:
 src/include/netif/ppp/ppp.h      |   24 ++++++++++-----------
 src/include/netif/ppp/ppp_opts.h |    4 ++--
 src/netif/ppp/auth.c             |   12 +++++++++--
 src/netif/ppp/lcp.c              |    6 +++++-
 src/netif/ppp/ppp.c              |   27 ++++++++++++++++-------
 src/netif/ppp/pppoe.c            |   44 ++++++++++----------------------------
 src/netif/ppp/pppol2tp.c         |   33 +++++++++++-----------------
 src/netif/ppp/pppos.c            |    4 ++--
 src/netif/ppp/vj.c               |    4 ++--
 9 files changed, 76 insertions(+), 82 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack