[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-1465-g98008cb

[Sylvain Rochet]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  98008cb1ab5d16391ddcb6a4106bc49f3f0c5f24 (commit)
       via  a56519032e466c0d773229627f57e3a0b623cea0 (commit)
       via  047c3c6528eaa6eb42cd6cb882e05edbcf2bd4a3 (commit)
       via  5b8760601bf7e2b670b0a41b7c72d8dd46ea1e00 (commit)
       via  b9fe13c105235c9b790a8a217f566548022ec8a5 (commit)
      from  a48ff4aaf2a52423504b5f5d8f3a5cf44aa0e7aa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 98008cb1ab5d16391ddcb6a4106bc49f3f0c5f24
Author: Sylvain Rochet <address@hidden>
Date:   Fri Jun 15 14:05:06 2018 +0200

    PPP, PPPoL2TP: use expected peer NS instead of current peer NS
    
    We never use the current peer NS value but always the next expected peer
    NS value (current value plus one).
    
    Signed-off-by: Sylvain Rochet <address@hidden>

commit a56519032e466c0d773229627f57e3a0b623cea0
Author: Sylvain Rochet <address@hidden>
Date:   Fri Jun 15 13:51:56 2018 +0200

    PPP, PPPoL2TP: drop unexpected packets from peer
    
    Conform a little bit more to the RFC by dropping duplicate received
    packets. It might help discover Ns sequence issues.
    
    Signed-off-by: Sylvain Rochet <address@hidden>

commit 047c3c6528eaa6eb42cd6cb882e05edbcf2bd4a3
Author: Sylvain Rochet <address@hidden>
Date:   Fri Jun 15 01:33:07 2018 +0200

    PPP, PPPoL2TP: take care of Ns/Nr wraparounds
    
    It can't be an issue since we only send and receive a few L2TP control
    packets and we don't care about anything received next other than
    sending Ack packet. For the sake of correctness properly handle Ns/Nr
    counters wraparounds, it doesn't add more code anyway.
    
    Signed-off-by: Sylvain Rochet <address@hidden>

commit 5b8760601bf7e2b670b0a41b7c72d8dd46ea1e00
Author: Sylvain Rochet <address@hidden>
Date:   Fri Jun 15 00:47:29 2018 +0200

    PPP, PPPoL2TP: wait for ICCN ack before starting PPP
    
    L2TP tunnel is really UP only once we received the ICCN Ack packet,
    generally with a ZLB packet. We actually drop all data packets until
    we reach the "data" L2TP state, which is a sane thing to do, therefore
    it makes no sense at all to start the PPP session a bit earlier.
    
    Signed-off-by: Sylvain Rochet <address@hidden>

commit b9fe13c105235c9b790a8a217f566548022ec8a5
Author: Sylvain Rochet <address@hidden>
Date:   Thu Jun 14 23:31:09 2018 +0200

    PPP, PPPoL2TP: fix ZLB packets Ns value
    
    Our Ns counter is the current slot rather than the next to ease packet
    retransmission. Therefore we increment the Ns counter before using the
    next slot instead of after. The RFC is written with post-increment in
    mind rather than pre-increment, thus when the RFC says that Ns in not
    incremented for ZLB packets it actually means that ZLB packets are sent
    with the next Ns without post-incrementing the Ns value, meaning the
    ZLB packet does not take a slot. Since we are using a pre-incremented
    value for real slots we need to send ZLB packets with our current Ns
    value plus one.
    
    Signed-off-by: Sylvain Rochet <address@hidden>

-----------------------------------------------------------------------

Summary of changes:
 src/include/netif/ppp/pppol2tp.h |  2 +-
 src/netif/ppp/pppol2tp.c         | 36 ++++++++++++++++++++++++------------
 2 files changed, 25 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack