lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] Bug in Checksum implementation and ARP fix


From: Leon Woestenberg
Subject: Re: [lwip-devel] Bug in Checksum implementation and ARP fix
Date: Fri, 24 Oct 2003 08:25:33 +0200

Hello,

From: "Kenneth Porter" <address@hidden>
> --On Thursday, October 23, 2003 9:47 AM +0100 Kieran Mansley
<address@hidden>
> wrote:
> > ...
> > checksum routines architecture specific, it should be sufficient for the
> > time being to fix the existing checksum function and remind developers
to
> > be careful when casting.
>

> ...
> So make your assumptions about word sizes (and buffer packing) explicit,
> either by using macros for conversions, or by heavy use of comments.
>
I think this issue deserves a code review for such occurences of casts.
Everyone is welcome to submit bug reports, or patches against this.

If CVS commit access is needed, we can provide this to developers
willing to improve the code.

Regards,

Leon.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]