Re: [PATCH] (was Re: [lwip-devel] pbuf_chain followed by pbuf_free )

[Jani Monoses]

Hi

> Hello Jani,
> 
> > and here's the patch for review
> > 
> 
> The documentation scares me.

I just copied what was there already :)

> I think this is more appropriate: (RFC)
> 
> /* Concatenate pbuf (chain) tail after pbuf (chain) head and remove
> the
>  * reference of the caller to the tail pbuf (chain).

It does not explicitely remove that reference right? Isn't this comment
misleading? It more like takes over the reference.

>  * @note The caller MUST NOT reference tail afterwards.
>  *
>  * @see pbuf_chain()
>  *
>  */
> pbuf_cat(head, tail)
> 
> 
> /* Chain pbuf (chain) tail after pbuf (chain) head and maintain the
>  * reference of the caller to the tail pbuf (chain).
>  *
>  * @note The caller still references tail and must explicitly call
>  * pbuf_free() when it no longer uses the tail pbuf (chain).
>  *
>  * @see pbuf_cat()
>  *
>  */
> pbuf_chain(head, tail)
> 
Ok
Jani.