[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-devel] RFC: debug and asserts
From: |
Jani Monoses |
Subject: |
Re: [lwip-devel] RFC: debug and asserts |
Date: |
Tue, 4 Nov 2003 12:45:17 +0200 |
On Tue, 4 Nov 2003 10:53:17 +0000 (GMT)
Kieran Mansley <address@hidden> wrote:
> On Tue, 4 Nov 2003, Jani Monoses wrote:
> > 2) Change throughout the code constructs of the form:
> > #if TCP_DEBUG
> > LWIP_DEBUGF (TCP_DEBUG,......)
> > #endif
>
> No real objections here, but there are a couple of places where there
> is other stuff (calls to tcp_debug_print() for example) within the #if
> ...
> #endif. If you removed the #if in these cases it wouldn't always
> compile, as the functions aren't defined when the debug flag is off.
> At least, it used to be like that - might have changed since I last
> looked at that bit of the code.
Yes, I checked and most of those functions have empty defines for the
nodebug case, some not (for udp). I'll fill those in as I remove the
ifdefs.
Jani