[lwip-devel] [bug #19052] ppp.h version 1.2 has broken Macros GETSORT/LONG

[Len Chisholm]

Follow-up Comment #1, bug #19052 (project lwip):

I expect the second line of the macro should contain (s)<<=8;

I think this is attempting to work around a problem which recurs (for me)
many times throughout lwip.
There are many macros which attempt to construct 16- or 32-bit quantities by
taking a number of bytes and shifting them left various amounts.
Unfortunately, in my compiler at least, taking a byte/char and shifting it
left by more than 7 bits is optimised completely away UNLESS the value is
first cast to a u16_t or a u32_t.

Len Chisholm.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19052>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/