[lwip-devel] [bug #19222] timeout in sys_mbox_fetch

[Dmitry Potapov]

Follow-up Comment #4, bug #19222 (project lwip):

I know that timeout handlers created per thread, but I don't like this
implicit assumption that there is no timeout handlers in the thread that
calls sys_arch_mbox_fetch with a finitive timeout.

> time = sys_arch_mbox_fetch(mbox, msg, min( timeout,
timeouts->next->time));

And you also need to verify that timeout is not 0. So, it should be something
like this:

time = sys_arch_mbox_fetch(mbox, msg, (time!=0) ? min( timeout,
timeouts->next->time) : imeouts->next->time));

Of course, it is possible to fix the bug in this way. But I don't understand
why should we add this extra parameter and overhead for anyone who does not
use UDP socket with the receive timeout? I think it is a better solution to
use sys_timeout() for recv_timeout as I did in my patch.



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19222>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/