[lwip-devel] [bug #19345] tcpip_apimsg+api_msg_post problem

[Frédéric Bernon]

Follow-up Comment #3, bug #19345 (project lwip):

api_msg_post() is only used in api_lib.c. Each call is the same sequence:

//Prepare message
api_msg_post(&msg);
sys_mbox_fetch(conn->mbox, NULL);

I propose to change api_msg_post like this :

err_t
api_msg_post( struct netconn *conn, struct api_msg *msg)
{ msg->msg.conn = conn;
  if (tcpip_apimsg(msg)==ERR_OK)
   { sys_mbox_fetch(conn->mbox, NULL);
   }
  return ERR_MEM;
}

And to change each call in api_lib.c like this:

err_t
netconn_disconnect(struct netconn *conn)
{
  struct api_msg msg;
  
  if (conn == NULL) {
    return ERR_VAL;
  }

  msg.type = API_MSG_DISCONNECT;
  api_msg_post( conn, &msg);

  return conn->err;

}

Your comments?



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19345>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/