[lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton

[Frédéric Bernon]

Follow-up Comment #9, bug #19177 (project lwip):

Because ARP can also be used with Token Ring (and even if this protocol is
not really supported now), I think that LWIP_ARP would be better. Ok to set
it to 1 as default value.

About etharp_init(), I don't understand why you want to call it inside
tcpip_thread? It's just a table initialisation, no timer is initialized
inside this function... So, why not like in comment #1, or why not there :

void
tcpip_init(void (* initfunc)(void *), void *arg)
{
#if LWIP_ARP
  etharp_init();
#endif
  ip_init();
#if LWIP_UDP
  udp_init();
#endif
#if LWIP_TCP
  tcp_init();
#endif

  tcpip_init_done = initfunc;
  tcpip_init_done_arg = arg;
  mbox = sys_mbox_new();
  sys_thread_new(tcpip_thread, NULL, TCPIP_THREAD_PRIO);
}

I just want to understand your point of view (perhaps I miss something)...




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19177>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/