[lwip-devel] [patch #5823] move #include <errno.h> from sockets.c to arch.h to prevent warning

[Frédéric Bernon]

Follow-up Comment #2, patch #5823 (project lwip):

What !!!! I forget to comment !!! Shame on me !!!! :) But it was what I
wanted to say, if no answers, I think you can commit if you think it's good.
If there is problem, you will be informed I suppose, by a user who is "wake
up" with a new problem.

I have always supposed that errno.h exist on any C compiler+platform SDK.
Perhaps it's wrong, but...

Just, in sys_arch.txt, we can read :

"This file must either include a system-local <errno.h> which defines the
standard *nix error codes, or it should #define LWIP_PROVIDE_ERRNO to make
lwip/arch.h define the codes which are used throughout."

So, I suppose that just remove <errno.h> in sockets.c is need. The second
part is not really useful. But if you want to add something, you can add :

+#else
+#if (ENOBUFS==0)
+#error "You have provide to provide errno. Please read sys_arch.txt"
+#endif /* (ENOBUFS==0) */
 #endif /* LWIP_PROVIDE_ERRNO */

If you prefer your idea, please, also update sys_arch.txt...


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5823>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/