[lwip-devel] [patch #5824] gratuitous ARP

[Frédéric Bernon]

Follow-up Comment #9, patch #5824 (project lwip):

I think your patch is not good, because non-ethernet interfaces are not
break, just because... NETIF_FLAG_ETHARP should only be used on ethernet
devices (which can used etharp_ functions)!!! :)

loopif, slipif and ppp don't have to set (and don't set) NETIF_FLAG_ETHARP.

But this problem is more that 

if ((netif->flags & NETIF_FLAG_ETHARP) == 0) in netif_set_up

should be 

if ((netif->flags & NETIF_FLAG_ETHARP) != 0)

Thank for this fix...


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5824>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/