[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE : RE : [lwip-devel] Snmp changes
From: |
Frédéric BERNON |
Subject: |
RE : RE : [lwip-devel] Snmp changes |
Date: |
Tue, 3 Apr 2007 10:12:28 +0200 |
>Strange, I didn't receive one, either. That's why I didn't realize I had
>checked it in until this morning...
And this is not the first time I think (one of your last commit got the same
"problem", but I thougth it was our messaging system which perhaps got a
problem).
>Because there's another variable named at_node in the file somewhere (e.g. in
>snmp_insert_arpidx_tree()) and using the g_ for global I had to change little:
>the global at_node is only referenced once.
Ok. I just think is "strange" to only use "g_" prefix in this case (snmp_ is
more in lwip style?). Is it something to define or add in the contrib.txt ? I
also got a style question: there is some extra LF in some code. Is it to avoid
to reach column 80 (or other)? Is there any rules to respect on that? I prefer
to let editors do the "break" than do it manually, just because all editors
don't do it with the same rules
====================================
Frédéric BERNON
HYMATOM SA
Chef de projet informatique
Microsoft Certified Professional
Tél. : +33 (0)4-67-87-61-10
Fax. : +33 (0)4-67-70-85-44
Email : address@hidden
Web Site : http://www.hymatom.fr
====================================
P Avant d'imprimer, penser à l'environnement
-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Goldschmidt Simon
Envoyé : mardi 3 avril 2007 10:05
À : lwip-devel
Objet : RE: RE : [lwip-devel] Snmp changes
> I look your modifications, I don't think there is any problem
> (except I don't have receive any lwip-comits email?). Just
Strange, I didn't receive one, either. That's why I didn't realize I had
checked it in until this morning...
> about one of these modifications, why rename g_at_node (I can
> understand for others, but this one is strange)?
Because there's another variable named at_node in the file somewhere (e.g. in
snmp_insert_arpidx_tree()) and using the g_ for global I had to change little:
the global at_node is only referenced once.
Simon
_______________________________________________
lwip-devel mailing list
address@hidden http://lists.nongnu.org/mailman/listinfo/lwip-devel
Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf
- RE : RE : [lwip-devel] Snmp changes,
Frédéric BERNON <=