[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #5865] Fix missing lwip directory in socket.h includ
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path |
Date: |
Sun, 13 May 2007 14:06:15 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3 |
Follow-up Comment #11, patch #5865 (project lwip):
>While I initially agreed with Simon, I'm not sure now, given that I notice
that both TCP_KEEPALIVE and TCP_MAXIDLE are used in the lwIP core code.
Correct me if I'm wrong, but TCP_KEEPALIVE is not used in the core code and
TCP_MAXIDLE shouldn't be moved to sockets.h since it is not used in
sockets.c. I've prepared a patch moving the #include "lwip/tcp.h" from
sockets.h to sockets.c and moving TCP set/getsockopt options from tcp.h to
sockets.h since they are _only_ used in sockets.c! Those are the following:
- TCP_NODELAY
- TCP_KEEPALIVE
- TCP_KEEPIDLE
- TCP_KEEPINTVL
- TCP_KEEPCNT
This patch removes socket application dependancy from core headers.
(file #12763)
_______________________________________________________
Additional Item Attachment:
File name: sockets_h_include.patch Size:3 KB
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?5865>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path,
Simon Goldschmidt <=
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Jonathan Larmour, 2007/05/13
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Simon Goldschmidt, 2007/05/13
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Frédéric Bernon, 2007/05/14
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Simon Goldschmidt, 2007/05/14
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Frédéric Bernon, 2007/05/14
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Jonathan Larmour, 2007/05/14
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Simon Goldschmidt, 2007/05/14
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Frédéric Bernon, 2007/05/21
- [lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path, Kieran Mansley, 2007/05/22