[lwip-devel] [task #6933] Review usage of ASSERT and error handling with LWIP_NOASSERT

[Frédéric Bernon]

Follow-up Comment #2, task #6933 (project lwip):

For api_lib.c patch, I'm disagree with you: we have replace the "conn==NULL"
check by assert, because it's most an application programmer task (always
done when you have good developers in your team) and it's redundant here
(more cycles & footprint).

If your really want to handle such cases inside your code, why not something
like (defined or not, perhaps with a define in cc.h):

#define LWIP_ASSERT2(x,y,ret) do { if(!(y)) { LWIP_PLATFORM_ASSERT(x); return
ret;} while(0)

And let each one decide to handle or not such checks in there production
code

More, for the same reason we have do this change, I propose to replace in
sockets.c any code like this... "if (!sock) return -1;" ...by an assert (once
again, it's at the application to check that, like it check to pass an valid
value to API).



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?6933>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/