[lwip-devel] [task #7017] Implement DNS client

[Frédéric Bernon]

Follow-up Comment #12, task #7017 (project lwip):

>Did I forget anything?? 

- MAX_NAME_LENGTH is a too generic name (MAX_RETRIES also). Add something ine
hte name like DNS or FQDN and LWIP. Put the define in dns.h, with a block like
#ifndef/#define/#endif to let the possibility to set the value in lwipopts.h
(like you have proposed). In a general way, all this kind of define should
have this kind of block, and default should be RFC compliant (timeouts,
delays, ...).

- I think you have forget : "- If your send in a short time (shorter than the
"not found" timeout) more than LWIP_RESOLV_ENTRIES, the older client of resolv
is "lost" but not its callback "found" will never be called (like in
STATE_ERROR case). " (from comment#7).

- Tips in comment#8

- And of course, some typo and coding style to do, like explain in
contrib.txt file (If you want to see some samples, look in last month
"lwip-commits", Simon have do a big job on that, you can see what he
changed).

- Perhaps replace #define STATE_ by enum like in some other lwip files
(tcp_state, netconn_state...). To my point of view, it's not very nice to
have define inside typedefs, and declarations from MAX_NAME_LENGTH to
DNS_TABLE_ENTRY should be more in dns.h (but not all lwip modules do
that)...

>(I'll need CVS write access, btw..) 

Send an email to Kieran for that...



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7017>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/