[lwip-devel] [bug #20900] Potential crash error problem with netconn_peer & netconn_addr

[Frédéric Bernon]

Follow-up Comment #3, bug #20900 (project lwip):

I got a first partial patch, but I see another problem with the netconn_addr
prototype:

err_t netconn_addr(struct netconn *conn, struct ip_addr **addr, u16_t
*port);

In these parameters, we don't get the "addr", but a pointer to the internal
pcb's addr. So, even if we move the code in tcpip_thread context, this
function is not very safe-thread. The better solution will  be to change the
prototype to :

err_t netconn_addr(struct netconn *conn, struct ip_addr *addr, u16_t *port);

But it break the netconn API. Thoughts about that?


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20900>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/