[lwip-devel] [task #7490] Add return value to sys_mbox_post

[Frédéric Bernon]

Update of task #7490 (project lwip):

        Percent Complete:                      0% => 20%                    
         Planned Release:                    None => 1.3.0                  

    _______________________________________________________

Follow-up Comment #22:

I attach a first partial patch file:

"size" parameter is added to sys_mbox_new, err_t sys_mbox_trypost(sys_mbox_t
mbox, void *msg) is declared and documented, and sys_mbox_trypost is used, but
some points need to be checked :

1/ If tcpip_callback is non-blocking, we will got problems with lwip_get/set
sockopt, and with PPP, so, perhaps we could add a "block" parameter to this
function if someone need to used is non-blocking (which is not the case in CVS
code)

2/ tcpip_input used "trypost", other in tcpip.c used "post"

3/ calls in err_tcp are blocking: I didn't check (yet), but on error, these
"NULL" messages could be important. Have to investigate

4/ in accept_function, if "trypost" failed, we have to close the new
pcb/netconn. Something like a "netconn_free" could be useful. I put a @todo to
not forget it

5/ netconn::mbox have to be change with a semaphore (have to use
sys_arch_sem_wait and sys_sem_signal)



(file #14748)
    _______________________________________________________

Additional Item Attachment:

File name: sys_mbox_trypost.patch         Size:7 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7490>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/