RE : [lwip-devel] Rename some options before 1.3.0

[Frédéric BERNON]

I'm agree we should stop to change code, but I see these - minor - changes like 
a way to have something "cleaner" before release (I see that like do changes in 
comments for doxygen documentation, fix minor warnings, or perhaps reorganize 
opt.h - pbufs options near mem options, etc...).

About the LWIP_ prefix, I'm agree it's something to add for define names too 
"simple", but for "LWIP_DHCP_AUTOIP_COOP -> AUTOIP_DHCP_COOP", I don't think we 
could have a conflict with a such define name. For post 1.3.0, perhaps it could 
be something to do, but to be honest, I'm not really sure (there were only 3-4 
little problems like that since previous release, so...).

Can I ask you to change your point of view for these three names? Or perhaps we 
could wait some others comments. Of course, if you're against, I will not do 
these changes. :)

====================================
Frédéric BERNON 
HYMATOM SA 
Chef de projet informatique 
Microsoft Certified Professional 
Tél. : +33 (0)4-67-87-61-10 
Fax. : +33 (0)4-67-70-85-44 
Email : address@hidden 
Web Site : http://www.hymatom.fr 
====================================
P Avant d'imprimer, penser à l'environnement
 


-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Kieran Mansley
Envoyé : mercredi 23 janvier 2008 09:49
À : Frédéric BERNON; lwip-devel
Objet : Re: [lwip-devel] Rename some options before 1.3.0


On Tue, 2008-01-22 at 22:49 +0100, Frédéric BERNON wrote:
> I propose to rename some options before release 1.3.0 (to get a better
> coherency for options names ) :
> 
> PBUF_POOL_SIZE -> MEMP_NUM_PBUF_POOL
> 
> ETHARP_TRUST_IP_MAC -> ARP_TRUST_IP_MAC
> 
> LWIP_DHCP_AUTOIP_COOP-> AUTOIP_DHCP_COOP
> 
> Comments ?

Probably best left till after 1.3.0 now.  In the past we've had complaints that 
defines like this don't have an "LWIP" in the name and so clash with some 
external code, so I think leaving LWIP in (for example in the last one) is a 
good idea.

Kieran



_______________________________________________
lwip-devel mailing list
address@hidden http://lists.nongnu.org/mailman/listinfo/lwip-devel

Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf