[lwip-devel] [bug #23230] Bug in sys_mbox_trypost, unix port

[Steinar Lieng Fredriksen]

URL:
  <http://savannah.nongnu.org/bugs/?23230>

                 Summary: Bug in sys_mbox_trypost, unix port
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: steinarlf
            Submitted on: Sunday 05/11/2008 at 12:35
                Category: Contrib
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 

    _______________________________________________________

Details:

If sys_mbox_trypost is called on a full sys_mbox, the function does not free
the mbox->mutex. A second sys_mbox_trypost on the same mbox will potentially
block forever. 

sys_arch.c:
(227)  if ((mbox->last + 1) >= (mbox->first + SYS_MBOX_SIZE))
(228)    return ERR_MEM;

Proposed fix:
  if ((mbox->last + 1) >= (mbox->first + SYS_MBOX_SIZE)){
    sys_sem_signal(mbox->mutex);
    return ERR_MEM;
  }




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?23230>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/