[lwip-devel] [patch #6519] Some small debug enhancements

[Jonathan Larmour]

Follow-up Comment #1, patch #6519 (project lwip):

Unfortunately I disagree with the stats_display() parts of the patch, as this
will cause the stats_display() function (with dependency on printf - a very
large function) to be included on any debugging build when stats are being
collected. On small targets the stats are collected solely for display by a
debugger as printf etc. will not fit. We should not usually be requiring
people to change code on small targets, only configuring via lwipopts.h. I
have ports which would no longer fit if printf were included.

For people with lots of memory, running out of memory is something to be
avoided. But for people on small targets, it's expected. So the change of the
debug message to LWIP_DEBUGF(1,....) when running out is not universally
useful, and will just result in lots of unwanted output on those targets. I
don't see any reason why it shouldn't keep the MEMP_DEBUG. After all, at
present it's the only LWIP_DEBUGF affected by MEMP_DEBUG anyway! Maybe it
would be ok to change the default of MEMP_DEBUG to LWIP_DBG_ON in
include/lwip/opt.h, but that would make it the only exception.

I think the etharp.c is ok in principle, but in practice it is not portable
as the struct eth_addr array fields are chars, but %02x will be expecting
something of type 'unsigned int'. I expect this to cause warnings on many
compilers. You would need to cast each argument to (unsigned).


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6519>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/