[lwip-devel] Re: [patch #6520] patch to shell.c and tcpdump.c in unix port

[Rishi Khan]

You could remove these. But this would require to shift the STAT_NUM  
and the description strings. I think that removing them would be a  
better patch. At the time, I was trying to get it to work at all and  
therefore chose the 'quick' way. But I like your solution better.

Rishi

On May 25, 2008, at 8:40 PM, Jonathan Larmour wrote:

> Follow-up Comment #1, patch #6520 (project lwip):
>
> Strictly you could also do this at a fine-grain for lots of stats,  
> not just
> LWIP_UDP, following the various <module>_STATS defines as used in  
> stats.h.
> That would be preferable, but at least it would be better for the  
> test to be
> on UDP_STATS rather than LWIP_UDP.
>
> Secondly, have I missed something or is there now any reason not to  
> just
> remove the output for Pbufs entirely, rather than use "" so that  
> they're
> always NULL?
>
> Thanks for looking at this.
>
>
>
>     _______________________________________________________
>
> Reply to this item at:
>
>   <http://savannah.nongnu.org/patch/?6520>
>
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.nongnu.org/