[lwip-devel] [patch #6528] lwIP crash with large ICMP messages.

[Jonathan Larmour]

Follow-up Comment #1, patch #6528 (project lwip):

I've personally been excruciatingly busy recently, but had filed his post to
look at later. I've looked at it now.

The solution can probably be:

static u8_t buf[LWIP_MEM_ALIGN_SIZE(IP_FRAG_MAX_MTU+MEM_ALIGNMENT-1)];

in fact. And similarly subtract one for the cited ram_heap in mem.c. In fact,
looking at ram_heap, the comment beside its definition says we need one struct
mem at the end, which is true, but then adds 2*SIZEOF_STRUCT_MEM, not just
SIZEOF_STRUCT_MEM. Anyone see a reason for this? Otherwise this space is just
wasted. There's another struct mem at the start, but adding space after
MEM_SIZE_ALIGNED won't be relevant for that.

It was added seemingly explicitly by Simon in revision 1.36 of mem.c, but the
cvs log message doesn't say why.

Simon?

Jifl


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6528>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/