[lwip-devel] [bug #23948] Few compiler warnings on ARM platform

[Huang Po Sung]

URL:
  <http://savannah.nongnu.org/bugs/?23948>

                 Summary: Few compiler warnings on ARM platform
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: geminicat
            Submitted on: Monday 07/28/08 at 10:11
                Category: TCP
                Severity: 3 - Normal
              Item Group: Compiler Warning
                  Status: None
                 Privacy: Private
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.3.0

    _______________________________________________________

Details:

There are few compiler warnings:

1:
tcp_out.c -> tcp_output_segment():

Original:

seg->p->payload = seg->tcphdr;

Suggested:

seg->p->payload = (void *)(seg->tcphdr);

2:
icmp.c -> icmp_input():

Original:

IPH_CHKSUM_SET(iphdr, inet_chksum(iphdr, IP_HLEN));

Suggested:

IPH_CHKSUM_SET(iphdr, inet_chksum((void *)iphdr, IP_HLEN));

3:
icmp.c -> icmp_dest_unreach():

Original:

idur->chksum = inet_chksum(idur, q->len);

Suggested:

idur->chksum = inet_chksum((void *)idur, q->len);

4:
icmp.c -> icmp_time_exceeded():

Original:

tehdr->chksum = inet_chksum(tehdr, q->len);

Suggested:

tehdr->chksum = inet_chksum((void *)tehdr, q->len);

5:
ip.c -> ip_input():

Original:

if (inet_chksum(iphdr, iphdr_hlen) != 0) {

Suggested:

if (inet_chksum((void *)iphdr, iphdr_hlen) != 0) {

6:
ip.c -> ip_input():

Original:

p->payload = iphdr;

Suggested:

p->payload = (void *)iphdr;

7:
ip.c -> ip_output_if():

Original:

IPH_CHKSUM_SET(iphdr, inet_chksum(iphdr, IP_HLEN));

Suggested:

IPH_CHKSUM_SET(iphdr, inet_chksum((void *)iphdr, IP_HLEN));

8:
ip_frag.c -> ip_reass():

Original:

IPH_CHKSUM_SET(fraghdr, inet_chksum(fraghdr, IP_HLEN));

Suggested:

IPH_CHKSUM_SET(fraghdr, inet_chksum((void *)fraghdr, IP_HLEN));

9:
ip_frag.c -> ip_frag():

Original:

IPH_CHKSUM_SET(iphdr, inet_chksum(iphdr, IP_HLEN));

Suggested:

IPH_CHKSUM_SET(iphdr, inet_chksum((void *)iphdr, IP_HLEN));

9:
msg_in.c -> snmp_pdu_dec_varbindlist():

Original:

    if ((derr != ERR_OK) ||
        (type != (SNMP_ASN1_UNIV | SNMP_ASN1_CONSTR | SNMP_ASN1_SEQ)) ||
        (len <= 0) || (len > vb_len))   /* added/modified by address@hidden */

Suggested:

    if ((derr != ERR_OK) ||
        (type != (SNMP_ASN1_UNIV | SNMP_ASN1_CONSTR | SNMP_ASN1_SEQ)) ||
        (len == 0) || (len > vb_len))   /* added/modified by address@hidden */





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?23948>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/