[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #24132] Cross-dependency between ip_addr.h and inet.h
From: |
Luca Ceresoli |
Subject: |
[lwip-devel] [bug #24132] Cross-dependency between ip_addr.h and inet.h |
Date: |
Wed, 27 Aug 2008 15:49:37 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 |
Follow-up Comment #3, bug #24132 (project lwip):
> moved declaration of struct in_addr from ip_addr.h to inet.h
I'm ok with this change, but one point is still there: ip4_addr1() and
similar macros in ip_addr.h use ntohl(), which is in inet.h.
Since thanks to your change now inet.h does not need ip_addr.h anymore, the
attached patch tries to go one step forward.
It simply swaps the dependancy: ip_addr.h includes inet.h and not the vice
versa.
I'm not 100% satisfied because it also silently makes inet.c (not .h)
dependent on ip_addr.h, but it might still be ok since ip_addr.h is mostly a
bunch of macros.
Er, the patch leaves to be fixed files (if any) that include inet.h but use
ip_addr.h.
(file #16367)
_______________________________________________________
Additional Item Attachment:
File name: inet-ip-addr.patch Size:0 KB
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?24132>
_______________________________________________
Messaggio inviato con/da Savannah
http://savannah.nongnu.org/