[lwip-devel] [bug #20511] No persist timer

[Kieran Mansley]

Update of bug #20511 (project lwip):

                  Status:                   Fixed => None                   
             Open/Closed:                  Closed => Open                   
            lwIP version:                    None => CVS Head               

    _______________________________________________________

Follow-up Comment #14:

OK, reopening.  I'll take another look when I get a chance, but not sure when
that will be.

If the previous version works for you, you should use that for the time
being, but it does have the problem that it won't probe for more window when
there is only a small amount available, and lwIP won't send in that case as we
refuse to segment packets to fill a small window.

I haven't had a look at the trace you provide in detail yet, but it will be
very useful when working on this, thanks.  The other end should ACK these
probes as they are effectively retransmissions.  It might not ACK the first
one, but the second will be a duplicate and so should always be ACKed.  

I can't remember why I didn't set the ACK flag, probably just didn't want to
work out what to put in the ACK field.  PSH isn't appropriate here.

Regarding the condition in tcp_receive, I think the condition is wrong as it
stands, but I'd prefer to change it to use the right_wnd_edge rather than the
absolute value of the window so that we only take notice of window changes
that increase the window.  By the time we get to that test we've established
that the segment contains no new data and acknowledges no new data, so the
only reason it would be interesting is if it had a larger window.  This is
probably a separate bug - could you open one and describe the problem you're
seeing with that condition?



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?20511>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/