[lwip-devel] [task #9032] Provide means to get Version of Stack and submodules

[David Empson]

Follow-up Comment #4, task #9032 (project lwip):

The LWIP_VERSION macro is broken for a 16-bit platform. The shift left 24 and
16 will drop the high order bits.

I suggest changing the macro by adding UL to the first two shift factors,
forcing a 32-bit shift operation.

#define LWIP_VERSION (LWIP_VERSION_MAJOR << 24UL | LWIP_VERSION_MINOR << 16UL
|
LWIP_VERSION_REVISION << 8 | LWIP_VERSION_RC) 

Alternatively, typecast at least the major and minor versions to u32_t before
doing the shift.


A query: what will be the version number of LWIP immediately after an
official release, when the first post-release change has been applied in CVS?
Will this mechanism require the version number of LWIP (at CVS-HEAD) to
immediately change to x.y.z+1 RC 0 as soon as the first patch is applied?

I also suggest that LWIP_VERSION_RC value of 0 should mean this is NOT a
release candidate, but just early accumulation of patches prior to approaching
a release. LWIP_VERSION_RC of 1 through 254 can be release candidates, and 255
is the final release. This would mean a comment change and definition of a new
constant, perhaps

#define LWIP_RC_DEVELOPMENT 0


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?9032>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/